Skip to content

Make CLI able to handle Unicode characters output on Windows console #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 2, 2024
Merged

Make CLI able to handle Unicode characters output on Windows console #968

merged 8 commits into from
Nov 2, 2024

Conversation

@bact
Copy link
Member

@bact bact commented Nov 2, 2024 •
edited
Loading

  • Split cli tests to test_cli.py and testx_cli.py, test_cli will have only tests that do not require additional dependencies
  • Use safe_print (Add pythainlp.tools.safe_print to handle UnicodeEncodeError on console #969) so it plays nicely with UnicodeEncodeError on Windows console
  • Also set utf-8 in cli code and in GitHub workflow, so it can print Unicode characters
  • Errors related to Unicode in command line tests are now fixed

@coveralls
Copy link

coveralls commented Nov 2, 2024 •
edited
Loading

Coverage Status

coverage: 39.162% (+6.0%) from 33.191%
when pulling 252e64e on bact:add-cli-tests
into 974b153 on PyThaiNLP:dev.

@bact bact added the tests Unit test, code coverage, test case label Nov 2, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bact bact changed the title Split test_cli and testx_cli Make CLI able to handle Unicode characters output on Windows console Nov 2, 2024
@bact bact mentioned this pull request Nov 2, 2024
Closed
@bact bact merged commit cf6997f into PyThaiNLP:dev Nov 2, 2024
24 checks passed
@bact bact deleted the add-cli-tests branch November 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests Unit test, code coverage, test case

Projects

PyThaiNLP
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bact @coveralls